Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web: Abandon CRA, use Vite for building web app and provide new glue for plugins #741

Merged
merged 11 commits into from
Jan 23, 2023
Merged

Web: Abandon CRA, use Vite for building web app and provide new glue for plugins #741

merged 11 commits into from
Jan 23, 2023

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Jan 19, 2023 •
edited
Loading

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

  • Create-React-App looks to be completely abandoned
  • CRA is very difficult in customization and pretty heavy

What is the new behaviour?

  • Migrated from CRA to Vite (Rollup inside!)
  • Developed newer glue for plugins based on Vite plugins (virtual modules)

Breaking changes (for web plugins)

  • All extensions of JSX files must be renamed from .js to .jsx
  • src/commons is no longer installed as file package (@mwdb-web/commons). For plugin integration, we have @mwdb-web/commons virtual module instead.
  • @mwdb-web/commons/api exposes api as named export instead of default export
  • @mwdb-web/commons/api exposes APIProvider and APIContext directly

@psrok1 psrok1 marked this pull request as ready for review January 20, 2023 17:47
@psrok1 psrok1 linked an issue Jan 23, 2023 that may be closed by this pull request
DeprecationWarning while booting Webpack dev server #613
Closed
4 tasks
@psrok1 psrok1 changed the title Web: Abandon CRA and use Vite for building web app Web: Abandon CRA, use Vite for building web app and provide new glue for plugins Jan 23, 2023
@psrok1 psrok1 merged commit 5e81388 into master Jan 23, 2023
@psrok1 psrok1 deleted the refactor/vite branch January 23, 2023 15:04
@psrok1 psrok1 mentioned this pull request Jul 30, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeprecationWarning while booting Webpack dev server
1 participant
@psrok1